chore(entropy) What's new #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
65
to
66
| - abstracted away the information from `EntropyStructs.Request` to the `Revealed` event for easier consumption. | ||
| - added a `callbackFailed` boolean to indicate if the callback failed. |
There was a problem hiding this comment.
nit: prefer the present tense -- "abstracts away" and "adds a"
There was a problem hiding this comment.
also instead of "abstracted away..." I'd say something like:
"Denormalizes fields from EntropyStructs.Request to a flat representation for easier consumption."
There was a problem hiding this comment.
Do we wanna mention the reliability upgrades in this doc?
There was a problem hiding this comment.
I was not sure about that. What do you think?
aditya520
added a commit
that referenced
this pull request
Jul 30, 2025
* chore(entropy) What's new * update * requested changes
aditya520
added a commit
that referenced
this pull request
Jul 30, 2025
* chore(entropy) Dyamic Fee table * update * update * alias viem * use entropy sdk * requested changes * updated package.json * kill me * Update solana_mainnet.json (#779) * Update solana_mainnet.json ADD JUPSOL TO DOCS * Update solana_mainnet.json --------- Co-authored-by: Ali Behjati <[email protected]> * chore(entropy) What's new (#778) * chore(entropy) What's new * update * requested changes * updated package.json * requested changes * prettier --------- Co-authored-by: KemarTiti <[email protected]> Co-authored-by: Ali Behjati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots